fix: deny action with default status 403 #1097
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to set
403
as default deny status code instead of delegating it to the connectors.Why?
If the rule
status
field is not set,Deny
action is currently setting the status code of the interruption equal to0
. Only at the connector level, there is some logic to convert the0
into a403
. Example in coraza-proxy-wasm:Delegating it to the connector leads to
SecAuditLogRelevantStatus
not working properly. The regex^(?:(5|4)(0|1)[0-9])$
tries to matchtx.interruption.Status
equal to0
without succeeding.This behaviour notably happens with CRS blocking rules that have the
deny
action not followed by an explicitstatus
.Possible workaround: